isomeme
ParticipantForum Replies Created
-
Marking this resolved, as both bug reports were acknowledged with fixes planned for the next release. Thanks, team!
In reply to: Doubled link to Home for static home page and 'select' menu mode
March 30, 2015 at 11:17 pm #44765Awesome, thanks.
Excellent, thanks very much.
I found the child-page-link ordering bug, and provided the fix on the bug report thread. There’s a misplaced comma in the ordering argument to the child page query.
I’m still stumped by the repeated Home link, however.
I have found (and locally fixed) the bug. In loop-children.php, line 13 in the current code is
‘orderby’ => ‘menu_order, title’,
The comma shouldn’t be there; the correct version is
‘orderby’ => ‘menu_order title’,
Should I submit a patch or something?
And actually, now that I think about it, a custom menu wouldn’t help here. This is about the sorting of child page links on the parent page. The fact that a default menu is generated from those relationships, and that this generated menu gets the ordering right, isn’t really relevant.
Site is: http://oto-usa.org/
I checked for plausible plugin conflicts and didn’t find any.
I can certainly use a custom menu if that’s the only way, but would prefer to avoid the additional maintenance overhead when changing pages if possible.
I’ve opened a pair of bugs on these two issues.
On the first issue, that thread doesn’t seem relevant. My select-based menu is working; it just doubles up the Home link.
On the second, I’d greatly prefer to use the same menu across desktop and mobile for ease of maintenance, and the default (page-tree-based) structure works great other than the ordering of “In this section” child pages at the bottom of a root page. Can I file a bug about this?
Awesome, that did the trick. I apparently skipped or messed up that step during my original install process.
Viewing 9 posts - 1 through 9 (of 9 total)