Graphene 1.5.4 missing getfile parameter

  • moon

    #2096

    During translatation, I found the following issue:

    ‘% comments’ Should be changed to ‘%s comments’

    comments.php:49

    loop-author.php:90

    loop.php:183

    Admin

    Syahir Hakim

    #18626

    Those strings are used for the comments_number() function argument. They really use % instead of %d. See http://codex.wordpress.org/Function_Reference/comments_number

    TobiF

    #18627

    OK. I get a warning from WIN/poedit on this one. It accepts % Comments, since it regards the “C” as a type indication (disregarding the space character).

    Should this be reported as a minor bug to WP development?

    TobiF

    #18628

    Oh.

    I deleted the extra character c in line 97 and made a new zip for you http://dl.dropbox.com/u/23975858/graphene-SV.zip.

    Poedit complains about fatal error, but it does compile and save, anyway. Maybe the fatality occurs after compilation and saving… 🙂

    Admin

    Syahir Hakim

    #18629

    The TwentyEleven theme does it this way:

    printf( _n( 'One thought on “%2$s”', '%1$s thoughts on “%2$s”', get_comments_number(), 'twentyeleven' ),
    number_format_i18n( get_comments_number() ), '<span>' . get_the_title() . '</span>' );

    Maybe I’ll use that.

    PS: I’ve downloaded the updated SV translation, thanks!

Viewing 5 posts - 1 through 5 (of 5 total)
  • You must be logged in to reply to this topic.
Do NOT follow this link or you will be banned from the site!